Multiple issubclass calls
issubclass can take multiple types, so there is no need to call them multiple times for each type.
issubclass returns True if the first argument is an subclass of specified type/types (and a class is considered a subclass of itself).
Given that these result in the same outcome:
Why not choose the easiest to read, write, and execute (the first one)?
Note also that as of Python 3.10, issubclass also accepts Union Type:
If our GitHub code review bot spots this issue in your pull request it gives this advice:
code-review-doctorbot just nowvalidation.py
1 | + | if isinstance(item, int) or isinstance(item, float): |
isinstance can take multiple types, so there is no need to call them multiple times for each type.
Suggested changes
- | if isinstance(item, int) or isinstance(item, float): |
+ | if isinstance(item, (int, float)): |
2 | + | pass |
Update validation.pyInstantly check if you have this issue for free
Works with tools you use
- Detect typos
- Avoid mistakes
- Prevent bugs
- Improve tests
- Read more
- Review PRs
- One click fix
- Clear advice
- Delta aware
- Read more
- Review PRs
- Fix suggested
- Clear advice
- Delta aware
- Read more
Read about how it works.