Logo of a fox dressed as a Doctor

Code Review Doctor

Verified by GitHub
GitHub integrationPython checksDjango checksDemoCheck repository

Missing await in coroutine call

Calling a coroutine without the await statement just returns the coroutine without actually running the function.

This can have the unexpected side-effect that your code is not executed at all. This demonstrates the importance of unit testing to highlight such issues.

If our GitHub code review bot spots this issue in your pull request it gives this advice:

code-review-doctorbotsuggested changes just now
async.py
1
+
async def task():
2
+
    download_files()
Calling a coroutine without the await statement just returns the coroutine without actually running the function.
Read more
Suggested changes
-
    download_files()
+
    await download_files()
Expand 3 lines ...
Commit suggestion
3
+
	
4
+
async def download_files():
5
+
    pass
Update async.py
Instantly check if you have this issue for free
    Works with tools you use
    Read about how it works.