Using list/set/dict literal syntax is simpler and computationally quicker than calling
A literal is a terse and easily understood way to write a value without having to call the Python builtin function. A literal is syntax that the parser recognises as writing an object directly. Some examples of literal syntax:
|datatype||builtin call||literal syntax|
set() is slower than using the literal syntax, because the function name must be looked up in the global scope.
There is also the risk that
set() have been rebound e.g, poor naming choices may result in a developer writing
list = [1, 2, 3]. This is poor naming decisions, but would you expect poor naming decisions break the code?
Given that these are completely equivalent:
Why not choose the easiest to read, write, and quickest to execute (the first one)?
If our GitHub code review bot spots this issue in your pull request it gives this advice:
Code Review Doctor will run this check by default. No configuration is needed but the check can be turned on/off using check code
use-comprehension in your pyproject.toml file.